feat: add accessor protocol support and refactor `stats/base/nanmin` #6211

rahulptl165 · 2025-03-19T21:06:41Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: na
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Resolves #5659 .

Description

What is the purpose of this pull request?

This pull request:

Adds new lib/accessors.js file.
Modified lib/nanmin.js and lib/ndarray.js .
Modified bechmarks, tests, example and docs files accordingly.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: refactor and add protocol support to stats/base/nanmin #5659

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

stdlib-bot · 2025-03-19T21:07:54Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/nanmin	$\color{green}297/297$ $\color{green}+100.00\%$	$\color{green}42/42$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}297/297$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

rahulptl165 · 2025-03-21T12:21:29Z

Hi @kgryte, Please review my PR. thanks

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/stats/base/nanmin/README.md

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/stats/base/nanmin/README.md

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/stats/base/nanmin/README.md

Signed-off-by: Athan <[email protected]>

kgryte · 2025-03-24T03:23:23Z

lib/node_modules/@stdlib/stats/base/nanmin/README.md

-        x[ i ] = round( (randu()*100.0) - 50.0 );
-    }
-}
+var x = discreteUniform( 10, -50, 50, {


How you refactored this example does not preserve the original logic. See, e.g., https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/dnanmax#examples

lib/node_modules/@stdlib/stats/base/nanmin/docs/repl.txt

kgryte · 2025-03-24T03:25:10Z

lib/node_modules/@stdlib/stats/base/nanmin/examples/index.js

-		x[ i ] = round( (randu()*100.0) - 50.0 );
-	}
-}
+var x = discreteUniform( 10, -50, 50, {


Same comment as README.

kgryte · 2025-03-24T03:26:02Z

lib/node_modules/@stdlib/stats/base/nanmin/lib/accessors.js

+/**
+* Computes the minimum value of a strided array, ignoring `NaN` values.
+*
+* @param {PositiveInteger} N - number of indexed elements


Suggested change

* @param {PositiveInteger} N - number of indexed elements

* @private

* @param {PositiveInteger} N - number of indexed elements

This function is not part of the package's public API.

kgryte · 2025-03-24T03:26:44Z

lib/node_modules/@stdlib/stats/base/nanmin/lib/nanmin.js

Would you mind renaming this file to main.js and updating index.js accordingly?

kgryte · 2025-03-24T03:27:27Z

lib/node_modules/@stdlib/stats/base/nanmin/lib/nanmin.js

 * var x = [ 1.0, -2.0, NaN, 2.0 ];
 * var N = x.length;
 *
 * var v = nanmin( N, x, 1 );


Let's go ahead and remove L39 and replace N here with x.length. The use of N in this example doesn't really add anything.

kgryte · 2025-03-24T03:28:07Z

lib/node_modules/@stdlib/stats/base/nanmin/lib/ndarray.js

 * var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0, NaN, NaN ];
 * var N = floor( x.length / 2 );
 *
 * var v = nanmin( N, x, 2, 1 );


You need to replace usage of floor in this example.

That may also apply to index.js.

kgryte · 2025-03-24T03:28:50Z

lib/node_modules/@stdlib/stats/base/nanmin/test/test.nanmin.js

+var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
 var Float64Array = require( '@stdlib/array/float64' );


L28 will need to be updated after renaming nanmin.js. May apply elsewhere, as well.

Signed-off-by: Athan <[email protected]>

kgryte

Left an initial round of comments.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

rahulptl165 · 2025-03-24T07:37:57Z

Hi @kgryte, I have addressed requested changes.

Signed-off-by: Athan <[email protected]>

stdlib-bot · 2025-06-05T07:28:37Z

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 19, 2025